chore: migrate to `oxfmt` by Saadnajmi · Pull Request #4019 · microsoft/fluentui-react-native

Saadnajmi · 2026-02-24T16:23:07Z

Description of changes

Following the footsteps of @tido64 in microsoft/react-native-test-app#2681 and microsoft/rnx-kit#3990

Note: Most of this PR (the first 3 commits at least) are mostly entirely AI generated

Verification

CI should pass

The time difference running with lage is nonexistent because it's dominated by the per-package execution. Running prettier * and oxfmt at root though...

prettier at root:
Executed in   26.97 secs

oxfmt at root:
Executed in    1.35 secs

Pull request checklist

This PR has considered (when applicable):

changeset-bot · 2026-02-24T16:23:14Z

🦋 Changeset detected

Latest commit: a5c45ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 82 packages

Name	Type
@uifabricshared/foundation-composable	Patch
@fluentui-react-native/experimental-appearance-additions	Patch
@uifabricshared/theming-react-native	Patch
@uifabricshared/foundation-settings	Patch
@fluentui-react-native/experimental-activity-indicator	Patch
@fluentui-react-native/experimental-native-font-metrics	Patch
@uifabricshared/foundation-compose	Patch
@fluentui-react-native/experimental-native-date-picker	Patch
@uifabricshared/foundation-tokens	Patch
@fluentui-react-native/eslint-config-rules	Patch
@fluentui-react-native/themed-stylesheet	Patch
@uifabricshared/themed-settings	Patch
@fluentui-react-native/contextual-menu	Patch
@uifabricshared/theme-registry	Patch
@fluentui-react-native/vibrancy-view	Patch
@fluentui-react-native/immutable-merge	Patch
@fluentui-react-native/focus-trap-zone	Patch
@fluentui-react-native/notification	Patch
@uifabricshared/theming-ramp	Patch
@fluentui-react-native/experimental-menu-button	Patch
@fluentui-react-native/interactive-hooks	Patch
@fluentui-react-native/persona-coin	Patch
@fluentui-react-native/menu-button	Patch
@fluentui-react-native/radio-group	Patch
@fluentui-react-native/react-configs	Patch
@fluentui-react-native/experimental-checkbox	Patch
@fluentui-react-native/dropdown	Patch
@fluentui-react-native/experimental-expander	Patch
@fluentui-react-native/overflow	Patch
@fluentui-react-native/composition	Patch
@fluentui-react-native/merge-props	Patch
@fluentui-react-native/use-styling	Patch
@fluentui-react-native/android-theme	Patch
@fluentui-react-native/default-theme	Patch
@fluentui-react-native/theming-utils	Patch
@fluentui-react-native/focus-zone	Patch
@fluentui-react-native/pressable	Patch
@fluentui-react-native/separator	Patch
@fluentui-react-native/babel-config	Patch
@fluentui-react-native/popover	Patch
@fluentui-react-native/experimental-shimmer	Patch
@fluentui-react-native/spinner	Patch
@fluentui-react-native/tooltip	Patch
@fluentui-react-native/memo-cache	Patch
@fluentui-react-native/use-tokens	Patch
@fluentui-react-native/theme-tokens	Patch
@fluentui-react-native/checkbox	Patch
@fluentui-react-native/jest-config	Patch
@fluentui-react-native/experimental-avatar	Patch
@fluentui-react-native/drawer	Patch
@fluentui-react-native/experimental-shadow	Patch
@fluentui-react-native/framework	Patch
@fluentui-react-native/use-slots	Patch
@fluentui-react-native/apple-theme	Patch
@fluentui-react-native/theme-types	Patch
@fluentui-react-native/win32-theme	Patch
@fluentui-react-native/callout	Patch
@fluentui-react-native/divider	Patch
@fluentui-react-native/persona	Patch
@fluentui-react-native/tablist	Patch
@fluentui-react-native/kit-config	Patch
@fluentui-react-native/experimental-stack	Patch
@fluentui-react-native/use-slot	Patch
@fluentui-react-native/avatar	Patch
@fluentui-react-native/button	Patch
@fluentui-react-native/switch	Patch
@fluentui-react-native/badge	Patch
@fluentui-react-native/input	Patch
@fluentui-react-native/stack	Patch
@fluentui-react-native/chip	Patch
@fluentui-react-native/icon	Patch
@fluentui-react-native/link	Patch
@fluentui-react-native/menu	Patch
@fluentui-react-native/text	Patch
@fluentui-react-native/theme	Patch
@fluentui-react-native/framework-base	Patch
@fluentui/react-native	Patch
@fluentui-react-native/adapters	Patch
@fluentui-react-native/styling-utils	Patch
@fluentui-react-native/tokens	Patch
@fluentui-react-native/codemods	Patch
@fluentui-react-native/scripts	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

README.md

Saadnajmi · 2026-02-24T16:31:26Z

scripts/src/tasks/format.js

+    examples: [['Format the current package', '$0 format']],
+  });
+
+  fix = Option.Boolean('--fix', false, {


@tido64 points out that the underlying thing in prettier is false by default, but true by default with oxfmt

Imo, it's a lot more useful to have --fix on by default and only use --check on CI. If I run format, it's because I want it to format my files, not tell me that I should format my files.

I made this change. @JasonVMo FYI since this differs from the rest of your fix mode stuff

Saadnajmi · 2026-02-24T16:54:00Z

Note: it is way faster to just run yarn oxfmt at root than to invoke per package with lage..

packages/components/Menu/src/MenuPopover/useMenuPopover.ts

scripts/src/tasks/format.js

scripts/src/tasks/lintPackage.ts

yarn.lock

Saadnajmi commented Feb 24, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

Saadnajmi commented Feb 24, 2026

View reviewed changes

tido64 reviewed Feb 26, 2026

View reviewed changes

packages/components/Menu/src/MenuPopover/useMenuPopover.ts Show resolved Hide resolved

scripts/src/tasks/format.js Outdated Show resolved Hide resolved

scripts/src/tasks/lintPackage.ts Show resolved Hide resolved

yarn.lock Show resolved Hide resolved

github-actions bot and others added 14 commits February 26, 2026 08:31

initial changes

607a5d1

replace commands

44a95e6

docs(changeset): chore: migrate to oxfmt

7c94f3b

missed a file

4f18f9f

Add types to lage config, make ESM

c2803b8

Make fix mode the default for format

4f2aa72

Apply suggestion from @Saadnajmi

74741ea

fixup lage config a little, add root format:check

7a8e420

remove beachball reference

2426c34

update format.js slightly

e0f3e1c

update config

f1d01dd

just run format at root

b8550db

update config again

331e32e

Run yarn format

a5c45ac

Saadnajmi force-pushed the oxfmt branch from 9f022f4 to a5c45ac Compare February 26, 2026 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate to `oxfmt`#4019

chore: migrate to `oxfmt`#4019
Saadnajmi wants to merge 14 commits intomicrosoft:mainfrom
Saadnajmi:oxfmt

Saadnajmi commented Feb 24, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Saadnajmi Feb 24, 2026

Uh oh!

tido64 Feb 26, 2026

Uh oh!

Saadnajmi Feb 26, 2026

Uh oh!

Saadnajmi commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Saadnajmi commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Verification

Pull request checklist

Uh oh!

changeset-bot bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Saadnajmi Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

tido64 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Saadnajmi Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Saadnajmi commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Saadnajmi commented Feb 24, 2026 •

edited

Loading

changeset-bot bot commented Feb 24, 2026 •

edited

Loading